Unable to read TCM uri from web Dav

Question

While upgrading from Tridion 2011 to Web 8.5, I am unable to read TCMURI from webDAV. Due to which custom templates are failing (below is the code snippet from one of such templates). Any Idea about this issue?

string pubwedav = tbbContext.GetContextPublication().WebDavUrl.ToString();
itemWebDavOrTcmUri = pubwedav + itemWebDavOrTcmUri;
//Retrieve the TcmUri of the Tridion Item
var tridionItem = tbbContext.RetrieveItemAsObject(itemWebDavOrTcmUri);
TcmUri tcmUri = tridionItem != null ? tridionItem.Id : null;

Answer 1

By simply looking at the code I have a gut feeling that the itemWebdavOrTcmUri is your issue, cause if it really can be an Item Webdav Url OR a TcmUri, you need to know which it is.

TcmUri.IsValidUri() should tell you if your variable, itemWEbDavOrTcmUri is a URI, in which case you can't append to the publication webdav url and expect the result to be a valid webdav url.

If it is indeed a webdav url, it probably already contains the publication portion of it, and for that matter, you shouldn't be appending it to the publication webdav url.

Your "question" (or lack of it) is very vague, so maybe adding some examples of the values of the variables or providing additional context on what you are trying to do, will allow "us" to help you out, with whatever issue you are having here...

Read the comments, and make sure you know "how to ask" questions in here.