Automatic Work activity failed in Tridion 2013 Workflow uses external activity

Question

I have a manual activity first and then 2nd activity is an automatic decision activity. I have written a C# class library and uploaded in TCM as TBB. In my automatic decision activity, I have provided the code as below in the Edit script.

AssemblyTbbId = "/webdav/xyx/myworkflow.tbbasm"
Type = "myworkflow.myclass"

And below is the code in my TBB. I am getting the error below.

Tridion.ContentManager.Workflow.WorkflowEngineException: Activity instance '2. Super User?' (tcm:2-32-131104) must be in 'Finished' state after script

log is also not created in the TCM server. Do i need to register the dll in TCM? I just uploaded in TCM only.

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Tridion.ContentManager;
using Tridion.ContentManager.CoreService.Client;
using Tridion.ContentManager.CoreService.Workflow;

namespace myworkflow
{
public class myclass : ExternalActivity
{        
    protected override void Execute()
    {
        logdetails("Inside checkSuperUser method");
        SessionAwareCoreServiceClient cSclient = new SessionAwareCoreServiceClient();
        ActivityInstanceData currentActivityInstance = cSclient.Read(ActivityInstance.Id, new ReadOptions()) as ActivityInstanceData;
        Boolean isSuperUser = GetLastPermformerIdofCreateAndEdit(currentActivityInstance);
        ActivityFinishData finishActivity = new ActivityFinishData();

        if (isSuperUser)
        {

            finishActivity.Message = currentActivityInstance.FinishMessage;
            finishActivity.NextActivityTitle = "Approver";                
        }
        else
        {
            finishActivity.Message = currentActivityInstance.FinishMessage;
            finishActivity.NextActivityTitle = "Editor";
        }
        cSclient.FinishActivity(currentActivityInstance.Id, finishActivity, new ReadOptions());
    }        
    }
    }

Answer 1

For an automatic decision activity I think you need to use a DecisionActivityFinishData, rather than an ActivityFinishData, and you need to set it's NextActivity property.

Also - I don't think you need to instantiate a new Core Service client or an object for the current activity - You are given these already as part of the inheritance of the ExternalActivity class.

Suggest you try an Execute method something like the following:

protected override void Execute()
{
    logdetails("Inside checkSuperUser method");
    Boolean isSuperUser = GetLastPermformerIdofCreateAndEdit(ActivityInstance);
    ActivityFinishData finishActivity = new DecisionActivityFinishData();

    if (isSuperUser)
    {
        finishActivity.Message = ActivityInstance.FinishMessage;
        finishActivity.NextActivity = GetNextActivityByTitle("Approver");
    }
    else
    {
        finishActivity.Message = ActivityInstance.FinishMessage;
        finishActivity.NextActivity = GetNextActivityByTitle("Editor");
    }

    CoreServiceClient.FinishActivity(ActivityInstance.Id,
        finishActivity,
        new ReadOptions());
}

My GetNextActivityByTitle method is as follows:

private LinkToActivityDefinitionData GetNextActivityByTitle(string nextActivityTitle)
{
    var currentActivity = (ActivityDefinitionData)CoreServiceClient.Read(ActivityInstance.ActivityDefinition.IdRef, new ReadOptions());
    var currentTridionActivity = (TridionActivityDefinitionData)currentActivity;

    foreach (var linkToTridionActivityDefinitionData in currentTridionActivity.NextActivityDefinitions)
    {
        if (String.Compare(linkToTridionActivityDefinitionData.Title, nextActivityTitle, StringComparison.OrdinalIgnoreCase) == 0)
        {
            return new LinkToActivityDefinitionData { IdRef = linkToTridionActivityDefinitionData.IdRef };
        }
    }
    return null;
}